Add variable-length output support to SHAKE digests - #23
Merged
Conversation
SHAKE128 and SHAKE256 are XOFs that can produce arbitrary-length output, but the constructors hardcoded fixed sizes (16 and 32 bytes). The infrastructure for variable length already existed (_variable_length flag, EVP_DigestFinalXOF dispatch in final()) but was inaccessible. Add a size parameter to both constructors with defaults matching the previous fixed values. On OpenSSL 1.1.x, the parameter is accepted but ignored (the default is always used) to prevent buffer overflow from EVP_DigestFinal_ex writing a fixed-size output. Four property tests (OpenSSL 3.0.x only) verify output length matches the requested size and that the XOF prefix property holds: a shorter output is a prefix of a longer output from the same input. Closes #6
SeanTAllen
added
the
changelog - added
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHAKE128 and SHAKE256 are XOFs that can produce arbitrary-length output, but the constructors hardcoded fixed sizes (16 and 32 bytes). The infrastructure for variable length already existed (
_variable_lengthflag,EVP_DigestFinalXOFdispatch infinal()) but was inaccessible.Adds a
sizeparameter to both constructors with defaults matching the previous fixed values, so existing code is unaffected. On OpenSSL 1.1.x, the parameter is accepted but ignored (the default is always used) to prevent buffer overflow fromEVP_DigestFinal_exwriting a fixed-size output.Four property tests (OpenSSL 3.0.x only) verify output length matches the requested size and that the XOF prefix property holds: a shorter output is a prefix of a longer output from the same input.
Closes #6