Build the examples during make test - #96
Conversation
The `examples` target is not in `.PHONY`, and `examples/` is a real directory, so make treated the target as already satisfied and never ran the recipe. `digest-example` calls `Digest.sha256()` outside a `try`. That stopped compiling when #92 made the `Digest` constructors partial. Because the target was skipped, no one saw it. Closes #72
|
Autonomous-mode decision log — PR-specific Issue #72's premise was false, and this PR fixes more than the Makefile. Cross-cutting decisions that touch every PR (scope of "the tasks", review depth) |
The
examplestarget is not in.PHONY, andexamples/is a real directory, so make treated the target as already satisfied and never ran the recipe.make testreported success without compiling any example.Turning the target on surfaced that
digest-exampleno longer compiles: it callsDigest.sha256()outside atry, which stopped being valid when #92 made theDigestconstructors partial. This fixes the example in the same change, since enabling the guard is what exposes the breakage.Closes #72