Remove a comment that describes a hazard that does not exist - #97
Merged
Conversation
`Array[U8].init` allocates through `Pointer[U8]._alloc`, which calls `@pony_alloc`. The comment drew a distinction from `@pony_alloc` plus `from_cpointer` that the garbage collector cannot see, and pointed at a ponyc issue that was never filed. `ssl/crypto/hash_fn.pony` and `ssl/crypto/digest.pony` use `@pony_alloc` plus `from_cpointer` in nine places. A reader who believed the comment read those as latent corruption. Closes #77
Member
Author
|
Autonomous-mode decision log — PR-specific No PR-specific judgment calls. The issue's fix direction (delete the comment) was |
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl/crypto/hmac_sha256.ponycarried a comment claimingArray.initavoids GC buffer corruption that@pony_allocplusfrom_cpointerwould cause, and citingponyc#4831.Array[U8].initallocates through the same@pony_alloc, so the garbage collector cannot tell the two apart, andponyc#4831was never filed.ssl/crypto/hash_fn.ponyandssl/crypto/digest.ponyuse@pony_allocplusfrom_cpointerin nine places. A reader who believed the comment read those as latent corruption.Closes #77