Take a ref receiver on the SSLContext option mutators - #98
Merged
Conversation
`_set_options` and `_clear_options` reconfigure the OpenSSL context, but took the default `box` receiver, which a `val` receiver satisfies. An `SSLContext` is held `val` once it is done being configured — `client` and `server` require it — so a `fun val` or `fun box` method added later could have reconfigured a frozen context and compiled. Closes #93
Member
Author
|
Autonomous-mode decision log — PR-specific No PR-specific judgment calls. One thing worth flagging: #93 is the only issue |
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_set_optionsand_clear_optionsreconfigure the OpenSSL context but took the defaultboxreceiver, which avalreceiver satisfies. AnSSLContextis heldvalonce configuration is done —clientandserverrequire it — so afun valorfun boxmethod added later could have reconfigured a frozen context and compiled. They arefun refnow, matching every other mutating setter on the type.Closes #93