fix: enable recursive scanning for custom wallpaper directories - #115
Merged
Conversation
mmstick
previously approved these changes
Jan 21, 2026
|
@ZeusCraft10 i am going to test/review this...can you fix the conflicts? |
jacobgkau
force-pushed
the
fix/wallpaper-recursive
branch
3 times, most recently
from
June 16, 2026 21:25
935c7af to
47bd85e
Compare
jacobgkau
force-pushed
the
fix/wallpaper-recursive
branch
from
June 16, 2026 21:25
47bd85e to
6e0b9e0
Compare
jacobgkau
approved these changes
Jun 16, 2026
jacobgkau
left a comment
jacobgkau
left a comment
Member
There was a problem hiding this comment.
I recreated pop-os/cosmic-epoch#2841 using a structure like this:
/home/system76/Wallpapers/
/home/system76/Wallpapers/Category-A/
/home/system76/Wallpapers/Category-B/
The wallpapers in the subfolders showed up for individual selection, but the background turned plain grey after turning the slideshow on. After installing this fix, the slideshow works as expected in this environment.
mmstick
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pop-os/cosmic-epoch#2841. Enables recursive scanning for custom wallpaper directories using WalkDir, consistent with XDG_DATA_DIRS behavior. Added a unit test to verify recursion.