WIP cosmic-session-lock-layer-v1 protocol - #2792
Draft
ids1024 wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 28, 2026
ids1024
added a commit
to pop-os/cosmic-greeter
that referenced
this pull request
Sep 4, 2026
ids1024
added a commit
to pop-os/cosmic-bg
that referenced
this pull request
Sep 8, 2026
Requires pop-os/cosmic-comp#2792, and change to cosmic-greeter.
ids1024
force-pushed
the
session-lock-layer
branch
from
September 8, 2026 21:42
74562ae to
bb5f8b7
Compare
Contributor
|
I tried this with glowberry. But it doesn't redraw. Looks like it's short circuiting: Lines 2049 to 2055 in bb5f8b7 It needs to handle show-on-lock layer: if let Some(session_lock) = &self.session_lock {
if let Some(output) = session_lock
.surfaces
.iter()
.find(|(_, v)| v.wl_surface() == surface)
.map(|(k, _)| k)
{
return Some(output);
}
// schedule redraw for commits by show-on-lock layers
return self.outputs().find(|o| {
layer_map_for_output(o)
.layer_for_surface(surface, WindowSurfaceType::ALL)
.is_some_and(|l| layer_show_on_lock(l.wl_surface()))
});
}recording-2026-09-08_17-36-53-trimmed.mp4 |
Member
Author
|
Yeah, there are a couple places that iterate over surfaces that still need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very rough draft of an implementation of a protocol to allow cosmic-bg to be shown on the lock-screen.
This could also be used by the panel, but we'll also need another protocol to notify the panel that the session is locked so it can hide applets that shouldn't be shown on the lock screen, and propagate that information to applets. That is more subtle to get right.