Skip to content

fix(xwayland): Properly hide KDE video bridge - #2801

Draft
FreddyFunk wants to merge 3 commits into
pop-os:masterfrom
FreddyFunk:fix/xwayland-video-bridge
Draft

fix(xwayland): Properly hide KDE video bridge#2801
FreddyFunk wants to merge 3 commits into
pop-os:masterfrom
FreddyFunk:fix/xwayland-video-bridge

Conversation

@FreddyFunk

@FreddyFunk FreddyFunk commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

I installed KDE Plasma alongside my COSMIC desktop installation, so I can use KDE when gaming. After logging in to COSMIC after the KDE installation, I ran into #1204. This properly fixes #1204

Without these fixes:

2026-08-31.20-39-56-firefox-hq.Copy.1.webm

With these fixes:

2026-08-31.20-28-33-firefox-hq.webm
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@FreddyFunk FreddyFunk changed the title Fix/xwayland video bridge fix(xwayland): Properly hide KDE video bridge Aug 31, 2026
@git-f0x

git-f0x commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Just a note that newer versions of KDE don't use the bridge anymore, afaik (I don't see it on COSMIC on Arch). But this is likely still a correctness improvement for the Xwayland impl (as mentioned in the issue).

@Drakulix Drakulix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is an improvement, but I don't think I like how the below layer is implemented here.

First of all, this is very targeted at the video bridge, which we don't officially support in the first place and thus only implements the Below layer. But proper support would also care about the above layer. Imo those should be treated as conceptionally being on the same layer as layer-shell Bottom and Top elements.

Second of all, I am not sure we want to implement the Below hint. Different to layer-shell, these are workspace specific, can be grabbed and the window can request on it's own to be placed below everything or above everything without any user intervention. And thus they suddenly can also not be tiled anymore?

I don't think any of this is good UX. Yes it fixes the Xwayland video bridge, but this gives the same ability to any X11 app and I question that we need to support this mess.

If we want to support it, then this needs to go through @pop-os/ux first and we need to discuss in detail how it shall work.

}
}
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I like the effective_alpha approach here. It is error prone, as you need to make sure to use it every time any window that is potentially from Xwayland is rendered. Imo this should simply be part of CosmicSurface::push_render_elements. There is no case where we don't want to respect the windows opacity. This is identical to AlphaModifier for wayland windows imo.

@FreddyFunk

Copy link
Copy Markdown
Contributor Author

Just a note that newer versions of KDE don't use the bridge anymore, afaik (I don't see it on COSMIC on Arch). But this is likely still a correctness improvement for the Xwayland impl (as mentioned in the issue).

I did a fresh install of the Fedora 44 COSMIC spin, updated everything and then added KDE Plasma and the KDE video bridge was installed 🤷‍♀️

@FreddyFunk
FreddyFunk marked this pull request as draft September 1, 2026 17:18
@FreddyFunk

Copy link
Copy Markdown
Contributor Author

@Drakulix yeah, that's fair. I converted this pull request to a draft while it goes through @pop-os/ux first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Wayland to X Recording bridge" is shown as a white tiled window

3 participants