Conversation
leviport
approved these changes
Aug 20, 2025
leviport
left a comment
leviport
left a comment
Member
There was a problem hiding this comment.
Looks like a great starting point to me
jacobgkau
marked this pull request as draft
August 20, 2025 21:45
jacobgkau
marked this pull request as ready for review
August 20, 2025 21:49
Member
Author
|
I was going to include the Open With dialog, but it's packaged in a separate repo: https://github.com/pop-os/xdg-desktop-portal-cosmic I'm assuming updates to COSMIC Files won't affect Open With dialogs until the version of |
Member
|
@jacobgkau yes, that is true |
jackpot51
approved these changes
Aug 21, 2025
jackpot51
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken up into categories to make it easier to read, but I was more concerned with making the order of operations as quick as possible for testing.