Skip to content

Migrate to Rust 2024 edition and update dependencies - #1165

Merged
jackpot51 merged 4 commits into
pop-os:masterfrom
git-f0x:dev
Sep 11, 2025
Merged

Migrate to Rust 2024 edition and update dependencies#1165
jackpot51 merged 4 commits into
pop-os:masterfrom
git-f0x:dev

Conversation

@git-f0x

@git-f0x git-f0x commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

The vergen crate removed git features, so I suppose it's a good time to switch to the about widget (closes #658).
Replaces xz2 with lzma-rust2, since updating zip causes a conflict without that (and it's a pure Rust crate).

ICU isn't updated since the changes are very extensive, and I'm not yet sure how to adapt everything.

Edit: Also fixes #290 with the libcosmic changes of icon::from_name handling.

@git-f0x
git-f0x force-pushed the dev branch 3 times, most recently from 69a3bc2 to 38fbe84 Compare September 6, 2025 10:05
Comment thread Cargo.toml Outdated
@git-f0x
git-f0x force-pushed the dev branch 2 times, most recently from d84bd64 to f14cf49 Compare September 8, 2025 10:36
Updates all dependencies other than ICU.
Enables the `dbus-config` libcosmic feature to fix theming responsiveness.
Also prevents the trash and network drive layer container from touching the edge of the window.
@wash2

wash2 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This seems to have somehow introduced an offset for the dnd cursor image. I'll help look into a fix for that, but it otherwise looks ok. I need to do some more testing to make sure the networks section is ok too.

@mmstick

mmstick commented Sep 9, 2025

Copy link
Copy Markdown
Member

Perhaps it'd be a good idea to expose the -sys features of these C libraries for the distributions that'd prefer to link to their system libraries?

@git-f0x

git-f0x commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

This seems to have somehow introduced an offset for the dnd cursor image.

I'm not noticing any offset different from before for dnd items. Is there any particular place to look?

This effectively reverts commit 19c2cef.
The changes don't seem to be necessary anymore. and this ensures the header bar matches the theme.
@wash2

wash2 commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This seems to have somehow introduced an offset for the dnd cursor image.

I'm not noticing any offset different from before for dnd items. Is there any particular place to look?

Nevermind, I tested the wrong branch, looks good.

@git-f0x git-f0x mentioned this pull request Sep 11, 2025
@jackpot51
jackpot51 merged commit f0cce9a into pop-os:master Sep 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icons don't update their size variants when scaling is changed

5 participants