Faster CI (cached deps & wild linker)#1583
Open
joshuamegnauth54 wants to merge 1 commit into
Open
Conversation
This improves CI a bit by using Wild, a linker written in Rust that is significantly faster than gold and lld, and caching dependencies. Dependencies are cached based on the lock file. In other words, deps are only rebuilt if they need to be rebuilt (i.e. if the lock files changes). Besides that, I removed the explicit rustup call in favor of an action. This prevents needlessly reinstalling Rust in CI (which didn't happen anyway; but you know, just in case). Finally, unrelated to everything else, I enabled logs for the tests. If a test fails, the logs may prove helpful.
Contributor
Author
|
It looks like builds are ~30 seconds faster. This first run had to build dependencies, so the subsequent runs should be even faster. |
Member
|
I don't think it is worth using a different linker just to save this time - what if it produces different results? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves CI a bit by using Wild, a linker written in Rust that is significantly faster than gold and lld, and caching dependencies.
Dependencies are cached based on the lock file. In other words, deps are only rebuilt if they need to be rebuilt (i.e. if the lock files changes).
Besides that, I removed the explicit rustup call in favor of an action. This prevents needlessly reinstalling Rust in CI (which didn't happen anyway; but you know, just in case).
Finally, unrelated to everything else, I enabled logs for the tests. If a test fails, the logs may prove helpful.
Draft since I want it to run first to make sure it works...which it should because I'm using the same CI elsewhere. 😆