feat: Make Cosmic Files show .exe icons like Dolphin - #1875
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hasn't been reviewed since I fixed what was pointed out |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
It looks like some of the thumbnails aren't PNGs (or they don't all have a transparent background when created). 
I used https://omnvert.com/en/tools/exe-viewer to quickly get a couple of the |
jackpot51
left a comment
jackpot51
left a comment
There was a problem hiding this comment.
It looks good, but I'm not sure why there needs to be a bundled thumbnailer. Once the thumbnailer file is installed in /usr/share/thumbnailers, then it will be loaded as an external thumbnailer from there
jklgrasso
left a comment
jklgrasso
left a comment
There was a problem hiding this comment.
The previously mentioned app icons are correct now.
Regression testing passed
Checklist
Basic navigation
- Middle-click opens directory in a new tab (not focused).
- Open two scrollable tabs. Scroll one tab, then switch to the other tab; it should not have scrolled.
- Hover over the top item in the folder, then scroll down until it's out of view (while still hovered).
On scrolling back up (with the mouse in a different position), the item should not have the hover highlight. - Right-click an item in the sidebar. No visual change should occur with the rest of the items.
- Remove an item from the sidebar, then re-pin it.
File operations
- Right-click -> Create a new folder, then enter it.
- Right-click in the empty folder -> Create a new file.
- Navigate to the parent folder, create another new file, then drag it into the created folder.
- Files can be renamed.
- Files can be opened with non-default apps & browsing store for new apps works.
- Normal right-click shows
Move to trashoption. - Shift right-click, and right-click followed by Shift, both show
Permanently deleteoption.
Advanced navigation & view settings
- Image and video thumbnails generate & display in local folders.
- Gallery preview shows with Spacebar.
- Details pane shows with Ctrl+Spacebar.
- Zoom in/out and reset to default zoom work.
- Ctrl+1 and Ctrl+2 switch between list and icon view.
- Ctrl+H shows/hides hidden files.
- Directories can be sorted at top or inline.
- Settings -> Theme works.
- Settings -> Type to Search affects behavior as designed.
- Single-click to open setting takes effect.
- Sorting options work.
- Cutting, copying, and pasting files works.
- F5 reloads current directory.
- Left sidebar can be collapsed and expanded.
External filesystems
- Add a network drive (e.g. SFTP) and navigate into it.
- Plug in a USB drive; able to mount, browse, and eject.
Integrations
- Desktop icons display as expected
- Drag-and-drop into Firefox works
| } | ||
|
|
||
| #[cfg(debug_assertions)] | ||
| fn dev_exe_thumbnail(path: &Path, metadata: &ItemMetadata, thumbnail_size: u32) -> Self { |
There was a problem hiding this comment.
Again, I am not sure why you need to embed the thumbnailer when there is an external one
There was a problem hiding this comment.
This PR is very close. If you'd like, I can merge it to an upstream branch and finish it. I will likely move the exe thumbnailer to another crate, so it is minimal and totally separate from the GUI.
There was a problem hiding this comment.
Sorry :D I keep working on this late at night. All good now? If not, sure merge it and finish it. Thank you either way!
4 participants
Implements [Feature Request] Make Cosmic Files show .exe icons like Dolphin #1656
Please provide feedback on this one. While it works I believe the code can be cleaned up/compacted more I may just lack the experience and knowledge to do so. (Very much a junior still with lots to learn)