feat(dialog): persist global sort option - #2039
Open
avnyu wants to merge 1 commit into
Open
Conversation
Add DEFAULT_SORT_OPTION_FALLBACK constant for the default sort option (Modified, false). Add dialog_sort_name field to State to track the dialog sort option. Add state_handler and state fields to Dialog to load saved state. Implement tab::Command::SetSort for Dialog to apply and persist sort options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: pop-os/xdg-desktop-portal-cosmic#258
Fixes: #1963
Allows file dialogs to save and load sort options via State.dialog_sort_name. Previously, dialogs always defaulted to descending modified time.
Tested using the dialog example. Changing sort options updates $HOME/.local/state/cosmic/com.system76.CosmicFiles/v1/dialog_sort_name, and opening new dialogs applies the stored option.
Also tested in archlinux using xdg-cosmic-portal-cosmic package built from archlinux PKGBUILD + patch to change cosmic-files dependency to this branch.
I did use LLM for code review and grammar check. No code is generated.