Add workspace-scoped window switcher activation modes#432
Open
erik-balfe wants to merge 5 commits into
Open
Conversation
1 task
Introduce alt-tab-workspace and alt-tab-all CLI/dbus actions that send SearchFiltered requests with the appropriate WorkspaceFilter. Route window-switcher searches through request_search so alt-tab mode keeps using SearchFiltered across startup, fill, and escape handling. Add WindowSwitcher cosmic-config defaults and ship the default config file. Path dependencies on pop-launcher are for stacked local review; switch to a pop-os/launcher git rev before merge once the launcher PR lands. Assisted by an AI coding agent; changes were reviewed, tested on COSMIC with multiple workspaces, and validated with CodeRabbit CLI review.
Parse dbus action names with args so panel Input activation works, route typed queries through request_search instead of raw Search, and clear alt_tab when opening the app launcher so filtering uses desktop entries rather than the window switcher path.
Clamp focused index after result updates, avoid cycling focus when the workspace filter changes, and do not auto-hide workspace-scoped alt-tab while waiting for deferred window metadata. Switch pop-launcher deps to the fork branch for stacked review, log window switcher config load failures, and reset workspace filter state on hide.
erik-balfe
force-pushed
the
feature/workspace-scoped-window-switcher
branch
from
10de7be to
5037b7f
Compare
Clear launcher items immediately when issuing a workspace-filtered alt-tab search so stale windows are not shown while results load. Trim widget IDs when the result list shrinks. Fix window switcher config loading for current cosmic-config API. Assisted by an AI coding agent; changes were reviewed and tested.
erik-balfe
force-pushed
the
feature/workspace-scoped-window-switcher
branch
from
5037b7f to
670eaf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds workspace-scoped window switcher activation modes for COSMIC.
alt-tab-workspace,alt-tab-all(and shift variants)request_search()routes alt-tab throughSearchFilteredWindowSwitchercosmic-config withdefault_scope: allInputdbus activation regressionsStacked dependency: pop-os/launcher#290. Uses temporary git dep on
erik-balfe/launcher#feature/workspace-filtered-window-searchfor review; switch topop-os/launcherrev before merge.Testing
alt-tab-workspace/alt-tab-allon multiple workspacesChecklist