Skip to content

refactor(wifi): show available networks before saved networks - #2185

Open
ziuus wants to merge 1 commit into
pop-os:masterfrom
ziuus:feat/wifi-available-networks-first
Open

refactor(wifi): show available networks before saved networks#2185
ziuus wants to merge 1 commit into
pop-os:masterfrom
ziuus:feat/wifi-available-networks-first

Conversation

@ziuus

@ziuus ziuus commented Sep 3, 2026

Copy link
Copy Markdown
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Summary

  • Moves the visible networks section to render before the known networks section in the WiFi settings page.
  • Currently available networks now appear at the top (sorted by signal strength).
  • Saved/known networks appear below (sorted alphabetically).
  • Matches the UX pattern of other distro DE settings apps where "available networks" take priority over "saved networks."
  • Preserves the existing search bar behavior (shown when 15+ networks are visible).

Motivation

Users opening the WiFi settings panel need to see nearby networks first — they're the primary action target. A long list of saved networks pushing available networks to the bottom was confusing and required scrolling.

Test plan

  • Open WiFi settings with several available networks and saved networks.
  • Verify available networks section appears at the top.
  • Verify saved networks section appears below.
  • Verify search bar still appears when 15+ networks are in range and filters correctly.
  • Verify connecting/disconnecting/forgetting still works for both sections.

Move the visible networks section to render before the known networks
section in the WiFi settings page, so currently available networks
appear at the top and saved networks below — matching user expectation
and common UX patterns in other DE settings apps.

Co-Authored-By: upstage/solar-pro4:free <noreply@upstage.ai>
@jacobgkau
jacobgkau requested a review from a team September 3, 2026 15:16

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR template that you removed from the description is required. Please add it back and fill it in.

@ziuus

ziuus commented Sep 4, 2026

Copy link
Copy Markdown
Author

Re-requesting review: template has been added back to the PR description per the maintainer's request. Let me know if anything else is needed.

@ziuus

ziuus commented Sep 4, 2026

Copy link
Copy Markdown
Author

cc @jacobgkau — I've added the required PR template back to the description (all checkboxes checked: AI disclosed, understand changes, commit message accurate, contribution tested, DCO signed). The body still has the original Summary / Motivation / Test plan. Could you take another look when you have a moment? Thanks.

@ziuus

ziuus commented Sep 4, 2026

Copy link
Copy Markdown
Author

cc @jacobgkau — friendly bump on the re-review request. The PR template has been restored with all checkboxes ticked (AI disclosed, understand changes, commit message accurate, contribution tested, DCO signed), and the body retains the original Summary / Motivation / Test plan.

Happy to make any further adjustments if there's something else needed. Thanks for taking a look when you have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants