Add toggle for keyboard layout change OSD - #2191
Open
6insanes wants to merge 1 commit into
Open
Conversation
Closes pop-os/cosmic-epoch#3853. Adds a toggler in the Input Sources section, next to the layout list, reading/writing the com.system76.CosmicOsd/show_keyboard_layout_osd cosmic-config key that cosmic-osd now checks before showing its layout-change indicator. Follows the same inline Config::new/get/set pattern already used for amplification_sink/amplification_source in the Sound page. English localization only; other languages come through Weblate. This change was implemented by Claude Code (Anthropic), directed, reviewed, and tested by the author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes pop-os/cosmic-epoch#3853.
Companion to pop-os/cosmic-osd#226, which adds a
com.system76.CosmicOsd/show_keyboard_layout_osdcosmic-configkey (default
true) thatcosmic-osdnow checks before showing itskeyboard-layout-change indicator.
This adds a toggler for that key in the Keyboard settings page, in
the Input Sources section next to the layout list. Reads/writes the
config directly with the same inline
Config::new/get/setpattern already used for
amplification_sink/amplification_sourcein the Sound page (no shared struct with
cosmic-osd, just the samestring key name, so there's no cross-crate dependency between the two
PRs). English localization only; other languages come through
Weblate.
This change was implemented by Claude Code (Anthropic), directed,
reviewed, and tested by the author (isolated KMS test session running
both patched binaries together, plus manual confirmation in the
author's real session).