Skip to content

Add toggle for keyboard layout change OSD - #2191

Open
6insanes wants to merge 1 commit into
pop-os:masterfrom
6insanes:keyboard-layout-osd-toggle
Open

Add toggle for keyboard layout change OSD#2191
6insanes wants to merge 1 commit into
pop-os:masterfrom
6insanes:keyboard-layout-osd-toggle

Conversation

@6insanes

@6insanes 6insanes commented Sep 8, 2026

Copy link
Copy Markdown

Closes pop-os/cosmic-epoch#3853.

Companion to pop-os/cosmic-osd#226, which adds a
com.system76.CosmicOsd / show_keyboard_layout_osd cosmic-config
key (default true) that cosmic-osd now checks before showing its
keyboard-layout-change indicator.

This adds a toggler for that key in the Keyboard settings page, in
the Input Sources section next to the layout list. Reads/writes the
config directly with the same inline Config::new/get/set
pattern already used for amplification_sink/amplification_source
in the Sound page (no shared struct with cosmic-osd, just the same
string key name, so there's no cross-crate dependency between the two
PRs). English localization only; other languages come through
Weblate.

This change was implemented by Claude Code (Anthropic), directed,
reviewed, and tested by the author (isolated KMS test session running
both patched binaries together, plus manual confirmation in the
author's real session).

  • I have disclosed use of any AI generated code in my commit messages.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Closes pop-os/cosmic-epoch#3853. Adds a toggler in the Input Sources
section, next to the layout list, reading/writing the
com.system76.CosmicOsd/show_keyboard_layout_osd cosmic-config key
that cosmic-osd now checks before showing its layout-change
indicator. Follows the same inline Config::new/get/set pattern
already used for amplification_sink/amplification_source in the
Sound page. English localization only; other languages come through
Weblate.

This change was implemented by Claude Code (Anthropic), directed, reviewed, and tested by the author.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to disable the keyboard layout change OSD

1 participant