Skip to content

Adjustable translucensy - #889

Open
snaggen wants to merge 2 commits into
pop-os:masterfrom
snaggen:adjustable_translucensy
Open

Adjustable translucensy#889
snaggen wants to merge 2 commits into
pop-os:masterfrom
snaggen:adjustable_translucensy

Conversation

@snaggen

@snaggen snaggen commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

I have, with the help of Claude Code, made a fix for #878 . Now the opacity configuration is now shown for frosted glass effect, but defaults to the opacity value for the Primary layer and not the Background layer which it was previously. I think Primary might be a bit low, but it is a lot better than using the same as the Background layer. I also restored the non-focus tint.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@snaggen
snaggen force-pushed the adjustable_translucensy branch from 74eccd0 to d007be8 Compare July 28, 2026 06:53
@snaggen

snaggen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Did some cleanup. And made frosted glass default opacity use BlurStrength::VeryLow by default since that seems to adjust after the users theme.

@snaggen

snaggen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

I wonder if it is better to add a separate slider and a blur_opacity setting, to be used only for frosted glass, where the slider have distinct steps matching the BlurStrenght enums. That way the blur opacity will always be relative the setting in cosmic-settings. Right now, it is relative to that until you change the value, then it gets fixed.
What do you think @jackpot51 ?

@snaggen
snaggen force-pushed the adjustable_translucensy branch from d007be8 to b3cd96f Compare July 28, 2026 11:08
@snaggen

snaggen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

I implemented a separate slider and config to keep the blur opacity relative the main blur settings.

@snaggen
snaggen force-pushed the adjustable_translucensy branch from b3cd96f to f661581 Compare August 22, 2026 10:16
snaggen and others added 2 commits August 22, 2026 12:23
Reverts a43b5ae, which dropped the dimming of the terminal background when
the window or pane is not focused. Only the shading is restored; nothing
else in that commit changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The opacity setting was ignored and its slider hidden while the
compositor's frosted glass effect was active, leaving no way to adjust
translucency in that mode.

Add a separate `blur_opacity` setting for that mode. It holds a level in
the theme's alpha map rather than a percentage, so it keeps following the
system-wide blur settings, and is resolved against the running theme
where it is applied — both lookups are matches on borrowed data, cheap
enough to do while rendering. Its slider steps through the levels in the
opposite order, since a higher blur strength means a lower alpha, and
carries no value label because the level is not an absolute opacity.

The default is `VeryLow`: translucent, but several steps more opaque than
the theme's own `frosted`, which is tuned for containers behind other
content rather than for terminal text.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@snaggen
snaggen force-pushed the adjustable_translucensy branch from f661581 to fef740e Compare August 22, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant