Skip to content

Let the shortcuts search box capture a key combo directly - #893

Open
Basit-Balogun10 wants to merge 1 commit into
pop-os:masterfrom
Basit-Balogun10:fix/882-search-shortcuts-by-key-combo
Open

Let the shortcuts search box capture a key combo directly#893
Basit-Balogun10 wants to merge 1 commit into
pop-os:masterfrom
Basit-Balogun10:fix/882-search-shortcuts-by-key-combo

Conversation

@Basit-Balogun10

Copy link
Copy Markdown

Instead of only matching by action name, the search box now live-captures an actual key combo when it's focused (e.g. hold Ctrl+Shift, press C), showing it as "Ctrl + Shift + ..." while modifiers are held and filtering the list to whatever's bound to it once the final key lands. Typing a plain character still falls back to the old keyword search.

Fixes #882

Demo:

search-keyboard-shortcuts-cosmic-term.mp4
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Instead of only matching by action name, the search box now live-captures
an actual key combo when it's focused (e.g. hold Ctrl+Shift, press C),
showing it as "Ctrl + Shift + ..." while modifiers are held and filtering
the list to whatever's bound to it once the final key lands. Typing a
plain character still falls back to the old keyword search.

Claude Code used to diagnose and validate.

Fixes pop-os#882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Shortcuts can be searched (in keyboard shortcuts)

1 participant