improv(circular): prevent caps from touching#1254
Merged
Merged
Conversation
wash2
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the circular progress indicator in COSMIC Store became a full circle at some points, so this prevents that from happening.
The downside is that animations don't stay in sync across different-sized circulars if some of them hit the clamp.
But using different sized circulars near each other in apps is probably very unlikely (and the issue can be avoided if the bar is made thin enough).
Another nice side-effect is that the min gap and min size are the same now (instead of size being larger, and the gap being smaller than MIN_ANGLE), which also makes small circulars (with a high enough bar thickness) shrink to a dot at min size, which I think looks quite nice!
I removed BASE_ROTATION_SPEED, since it doesn't seem to change anything from my testing.
Before:
before.webm
After:
after.webm