Skip to content

improv(circular): prevent caps from touching#1254

Merged
wash2 merged 1 commit into
pop-os:masterfrom
git-f0x:master
Apr 18, 2026
Merged

improv(circular): prevent caps from touching#1254
wash2 merged 1 commit into
pop-os:masterfrom
git-f0x:master

Conversation

@git-f0x

@git-f0x git-f0x commented Apr 18, 2026

Copy link
Copy Markdown
Contributor
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

I noticed that the circular progress indicator in COSMIC Store became a full circle at some points, so this prevents that from happening.
The downside is that animations don't stay in sync across different-sized circulars if some of them hit the clamp.
But using different sized circulars near each other in apps is probably very unlikely (and the issue can be avoided if the bar is made thin enough).

Another nice side-effect is that the min gap and min size are the same now (instead of size being larger, and the gap being smaller than MIN_ANGLE), which also makes small circulars (with a high enough bar thickness) shrink to a dot at min size, which I think looks quite nice!

I removed BASE_ROTATION_SPEED, since it doesn't seem to change anything from my testing.

Before:

before.webm

After:

after.webm

@jackpot51 jackpot51 requested a review from a team April 18, 2026 18:12
@wash2 wash2 merged commit 95756b1 into pop-os:master Apr 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants