improv(progress_bar): unify indeterminate animations#1257
Merged
Conversation
c162ce3 to
5a59ef0
Compare
wash2
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes both Linear and Circular have effectively the same animation (kind of matching how linear indeterminates usually look).
Also does some deduplication in circular with a few closures and avoids a divide by 0 when
cycle_durationis set to 0 (matching the behavior in therotation_durationcomment).Before:
Screencast_20260419_172047.webm
After:
Screencast_20260419_201908.webm
The original animation can be replicated with tweaks to min and wrap lengths (setting them to 0.0 and 1.0, respectively), so I wonder if it might be worth having methods for setting those?
The second commit adds animations between progress states:
Screencast_20260420_135309.webm
Screencast_20260420_135243.webm
Edit: I've renamed
rotation_durationandtraversal_durationtoperiodin order for both to have a similar API. Not sure if that's the best name (maybesweep_duration?).