Selectable Text + Context Menu#1288
Conversation
2a92236 to
f1592aa
Compare
|
Merged the changes in iced and updated libcosmic. |
642ecb1 to
c826d41
Compare
|
Still working on this. Not sure why I can't get the wayland popup context menu items to react to mouse hover consistently. I'll figure it out. |
|
I don't love the way that the context menu is created, but I understand that it makes this more of a drop-in change and support for the context menu less cumbersome in general. This creates the popup directly through sctk, but I wonder if it could use the surface That aside, for As for whether it is worth it to try to keep the best effort backward compatibility, I think that it generally is, but we could try to time this along with the changes for theme-v2, which also brings some slightly breaking changes. |
|
I'm working on another approach without needing to go to sctk directly. I'll push that soon. |
fix(test): `--feature wayland` only
c826d41 to
0f0e26c
Compare
The idea is that adding
.selectable()to anyTextshould:Also all
TextInputandTextEditorwidgets should automatically have the context menu (copy/cut/paste/select all) too. The user shouldn't need to add any special code to theirupdate()for any of the widgets.I have achieved the goals above with this implementation.
Still working on it. But I thought this is good enough in case there are any feedback.
The diff is kinda big, but two large files are
textandtext_editorwhich are just wrappers.