Use Salsa infrastructure for cross-file goto-definition #1254
Open
lionel- wants to merge 29 commits into
Open
Conversation
lionel-
changed the title
lionel-
changed the title
Only canonicalise when comparing against paths from external sources (e.g. normalised by R). Canonicalisation may corrupt the identity of paths sent by frontends, and may prevent matching files at all when they are deleted (at which point a non-canonicalised path sent by the frontend can't be matched against canonicalised paths we've stored as keys)
lionel-
force-pushed
the
oak/salsa-17-interning
branch
from
59a2813 to
0cd9628
Compare
lionel-
force-pushed
the
oak/salsa-18-goto-def-migration
branch
from
54473e0 to
399f3f3
Compare
lionel-
force-pushed
the
oak/salsa-17-interning
branch
from
0cd9628 to
25c9de8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1253
Progress towards #1212
Progress towards #1149
source()d files in scripts, or file collation in packages)Filegains aline_index()query.PositionEncodingis stored inLspConfig, mirroring r-aOne regression with the Salsa infra: we no longer analyse files outside of workspace. In the future we could add these as Salsa inputs via oak_scan. Would also require a non-lsp file watcher for out-of-workspace updates.
I recommend testing with #1259 to benefit from bug fixes and improvements in ulterior branches.