Send notifications to participants of a Beatmap Discussion on replies#13008
Open
notbakaneko wants to merge 5 commits into
Open
Send notifications to participants of a Beatmap Discussion on replies#13008notbakaneko wants to merge 5 commits into
notbakaneko wants to merge 5 commits into
Conversation
notbakaneko
commented
May 27, 2026
Comment on lines
+53
to
+55
| if ($discussion->user_id !== null) { | ||
| $userIds->push($discussion->user_id); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I think this might not be necessary since discussions should normally have a post, but the tests currently don't always have the starting post...
notbakaneko
force-pushed
the
feature/discussion-reply-notify-participants
branch
from
14bc206 to
20e8d98
Compare
Collaborator
|
I wonder if the #13017 should be done first (splitting manual and automatic watch options) |
Collaborator
Author
|
Maybe.... 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends notifications to all participants of problem or suggestion type Beatmap Discussions, not just the starter.
This is based on the reason the reasoning that if you are replying to a discussion, you are probably involved in it (and doesn't involve adding a watch toggle to every discussion).
Also made some of the tests more strict and give more information when the expected receiver ids don't match (because the
EventandQueueassertions don't tell you much which makes find it out annoying...)closes #12885