Merged
Conversation
bdach
requested changes
Apr 7, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
initial read-through, haven't even ran yet
Collaborator
|
Also test failures relevant, failing tests need to stop checking for presence of loading layer and use |
bdach
previously approved these changes
Apr 7, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
Pretty rudimentary in places:
- no placeholder when there are no results
- can enter whitespace in search and it'll just dump the start of the list of all users (web just stonewalls whitespace-only search terms)
- no pagination
- no indication when hitting web-side cap of max-20-per-page, max-100-ever results returned
but probably workable for a start
Can reproduce locally single-threaded and this appears to help.
bdach
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a private request for roundtable event usage. It’s also a common feature request, so I decided to spend a bit of time getting this working well-enough.
osu.2026-04-07.at.07.38.53.mp4
Delay loading spinner / loading layer initial load briefly to avoid flickering
There's cases in this overlay where loading takes a few milliseconds. The loading spinner gets annoying. This also happens elsewhere, so this could be considered a global fix. Separate PR? probably...
Ingest loading state of dashboard child content to show more correct loading layer
Each display had their own loading layer implementation, but this is already too deep (inside the scroll content) and doesn't display great when for instance, results don't take up the full screen height.