Open
Conversation
peppy
added
code quality
minetoblend
reviewed
Apr 9, 2026
|
|
||
| delay += 800; | ||
|
|
||
| bool playerTookDamage = OpponentScore.TotalScore > PlayerScore.TotalScore; |
Contributor
There was a problem hiding this comment.
This should probably use the damageInfo from the match state as source of truth instead of the scores (came up on discord a few days ago when you had issues with the damage animation playing for the wrong player).
Member
Author
There was a problem hiding this comment.
I haven't started to adjust this class yet behaviour wise. Didn't get to reading this line yet even 😅.
the case i mentioned was a zero difference game i think? i'd be worried if the scores here don't match the match details...
peppy
commented
Apr 9, 2026
osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/ResultsScreen.cs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Just the bare minimum code quality so I can start working on these classes.. Please push back if this doesn't seem better than what was already there. This is mostly autopilot fixing for me based on how I've been writing code for osu! to date. There are changes to the load process but nothing which should cause issues, I hope.
peppy
force-pushed
the
ranked-play-results-tidy
branch
from
0877541 to
3202b66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the bare minimum code quality so I can start working on these classes..
Please push back if this doesn't seem better than what was already there. This is mostly autopilot fixing for me based on how I've been writing code for osu! to date.
There are changes to the load process but nothing which should cause issues, I hope.