Skip to content

Skip prop-passing if route is a DOM element (fixes #226)#231

Open
developit wants to merge 1 commit intomainfrom
skip-dom-props
Open

Skip prop-passing if route is a DOM element (fixes #226)#231
developit wants to merge 1 commit intomainfrom
skip-dom-props

Conversation

@developit
Copy link
Copy Markdown
Member

@developit developit commented Sep 8, 2017

This fixes the following issue:

let div = render(
  <Router url="/?matches=hello">
    <div />
  </Router>
);

div.matches  // "hello" - should be DOM match() method

@developit
Copy link
Copy Markdown
Member Author

Note to self: tests need to be updated to only use components as children, and to test that elements as children do not receive router props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant