Cheking urls considering protocol-relative url#383
Open
18choi18 wants to merge 3 commits intopreactjs:mainfrom
Open
Cheking urls considering protocol-relative url#38318choi18 wants to merge 3 commits intopreactjs:mainfrom
18choi18 wants to merge 3 commits intopreactjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Router in a specific part of the web page, in other parts they may not know that they should add a native boolean attribute to a link tag for bypassing preact-router's link handling. Currently, in this case, if an anchor tag have protocol-relative url(ex, //www.11st.co.kr) for the value of href, the link can't avoid handling of preact-router because it starts with '/'.
Therefore, unintended handling occurs in the a tag that takes the protocol-relative url as the value of href. So I suggest modifying the regex.
From: If the value of href starts with '/'?
To: If the value of href starts with '/' but the next character is not '/'?