Allow addition of new language types (#789)#792
Open
jhradilek wants to merge 1 commit intopreservim:masterfrom
Open
Allow addition of new language types (#789)#792jhradilek wants to merge 1 commit intopreservim:masterfrom
jhradilek wants to merge 1 commit intopreservim:masterfrom
Conversation
Author
|
On the off chance this solution gets approved, I'd be of course happy to update |
raven42
reviewed
Oct 5, 2021
Comment on lines
+1402
to
+1404
| if has_key(a:typeinfo, 'deflang') | ||
| let ctags_args += ['--langdef=' . expand(a:typeinfo.deflang)] | ||
| endif |
Collaborator
There was a problem hiding this comment.
We might be able to just key off the deffile instead. Then there wouldn't need to be any new config keys. Can you give this a try and see if this works?
Suggested change
| if has_key(a:typeinfo, 'deflang') | |
| let ctags_args += ['--langdef=' . expand(a:typeinfo.deflang)] | |
| endif | |
| if has_key(a:typeinfo, 'deffile') | |
| let ctags_args += ['--langdef=' . a:typeinfo.ctagstype] | |
| endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve #789 and re-enable support for addition of a new language definition from within vim configuration without having to edit
~/.ctags.With this patch, if you need to define a language that is unknown to ctags and provide a custom file with
deffileas documented indoc/tagbar.txt, you can usedeflangas follows: