Skip to content

Downgrade oddbird popover back to 0.52.0#1305

Merged
rezrah merged 1 commit intomainfrom
rezrah/downgrade-oddbird
Apr 7, 2026
Merged

Downgrade oddbird popover back to 0.52.0#1305
rezrah merged 1 commit intomainfrom
rezrah/downgrade-oddbird

Conversation

@rezrah
Copy link
Copy Markdown
Collaborator

@rezrah rezrah commented Apr 7, 2026

Summary

Rolling back a project dependency to previous version to ensure comptability with downstream users.

Towards unblocking #1298

List of notable changes:

  • Roll back @oddbird/popover to 0.5.2

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

@rezrah rezrah requested a review from a team as a code owner April 7, 2026 22:51
Copilot AI review requested due to automatic review settings April 7, 2026 22:51
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

⚠️ No Changeset found

Latest commit: 7ce46aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 8 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-css Patch
@primer/brand-docs Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🟢 No design token changes found

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rolls back the @oddbird/popover-polyfill dependency used by @primer/react-brand to restore compatibility for downstream consumers (reverting part of the dependency upgrades introduced recently).

Changes:

  • Downgrade @oddbird/popover-polyfill in packages/react/package.json from 0.6.1 to 0.5.2.
  • Update package-lock.json to reflect the downgraded resolved package/version/integrity.
  • Update the existing changeset to remove the release-note line that claimed the dependency was upgraded.
Show a summary per file
File Description
packages/react/package.json Pins @oddbird/popover-polyfill back to 0.5.2 for @primer/react-brand.
package-lock.json Aligns lockfile entries with the downgraded @oddbird/popover-polyfill version.
.changeset/fruity-insects-jump.md Removes the line documenting the (now-reverted) popover polyfill upgrade.

Copilot's findings

  • Files reviewed: 2/3 changed files
  • Comments generated: 2

},
"dependencies": {
"@oddbird/popover-polyfill": "0.6.1",
"@oddbird/popover-polyfill": "0.5.2",
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description references downgrading to 0.52.0, but this dependency is set to 0.5.2. Please confirm the intended target version and align the PR metadata (or the dependency version) to avoid confusion for reviewers and release notes.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🟢 No unit test coverage changes found

All components and hooks with tests maintain the same coverage as the main branch.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah merged commit c5863b7 into main Apr 7, 2026
18 checks passed
@rezrah rezrah deleted the rezrah/downgrade-oddbird branch April 7, 2026 23:04
@rezrah rezrah mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants