Conversation
|
| Name | Type |
|---|---|
| @primer/react-brand | Patch |
| @primer/brand-primitives | Patch |
| @primer/brand-css | Patch |
| @primer/brand-docs | Patch |
| @primer/brand-e2e | Patch |
| @primer/brand-fonts | Patch |
| @primer/brand-config | Patch |
| @primer/brand-storybook | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
🟢 No design token changes found |
There was a problem hiding this comment.
Pull request overview
Rolls back the @oddbird/popover-polyfill dependency used by @primer/react-brand to restore compatibility for downstream consumers (reverting part of the dependency upgrades introduced recently).
Changes:
- Downgrade
@oddbird/popover-polyfillinpackages/react/package.jsonfrom0.6.1to0.5.2. - Update
package-lock.jsonto reflect the downgraded resolved package/version/integrity. - Update the existing changeset to remove the release-note line that claimed the dependency was upgraded.
Show a summary per file
| File | Description |
|---|---|
| packages/react/package.json | Pins @oddbird/popover-polyfill back to 0.5.2 for @primer/react-brand. |
| package-lock.json | Aligns lockfile entries with the downgraded @oddbird/popover-polyfill version. |
| .changeset/fruity-insects-jump.md | Removes the line documenting the (now-reverted) popover polyfill upgrade. |
Copilot's findings
- Files reviewed: 2/3 changed files
- Comments generated: 2
| }, | ||
| "dependencies": { | ||
| "@oddbird/popover-polyfill": "0.6.1", | ||
| "@oddbird/popover-polyfill": "0.5.2", |
There was a problem hiding this comment.
The PR title/description references downgrading to 0.52.0, but this dependency is set to 0.5.2. Please confirm the intended target version and align the PR metadata (or the dependency version) to avoid confusion for reviewers and release notes.
🟢 No unit test coverage changes foundAll components and hooks with tests maintain the same coverage as the main branch. |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
Summary
Rolling back a project dependency to previous version to ensure comptability with downstream users.
Towards unblocking #1298
List of notable changes:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: