Prepend the Next.js basePath to index card hrefs - #43
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures index cards use Next.js Link to respect the configured basePath, preventing 404s on sites with a custom basePath.
- Wrap each
<Card>in anext/linkto inheritbasePath - Import
Linkfromnext/linkand adjustCardhref - Add a changeset entry to release the patch
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/theme/components/layout/index-cards/IndexCards.tsx | Wrap cards in Link and change Card href prop |
| .changeset/chatty-trains-explode.md | Add changeset note for basePath support |
Comments suppressed due to low confidence (1)
packages/theme/components/layout/index-cards/IndexCards.tsx:94
- Consider adding a unit or integration test to verify that the rendered
hrefon each card includes the configuredbasePath, preventing regressions in future changes.
<Link legacyBehavior passHref href={item.route}>
| {item.frontMatter.description && <Card.Description>{item.frontMatter.description}</Card.Description>} | ||
| </Card> | ||
| <Link legacyBehavior passHref href={item.route}> | ||
| <Card href="#" hasBorder> |
There was a problem hiding this comment.
[nitpick] Using href="#" can trigger unwanted jumps and may confuse assistive technologies. Instead, remove the explicit href prop and let Link passHref supply the correct URL, or use as="a" on Card to ensure the link behavior without a placeholder.
Suggested change
| <Card href="#" hasBorder> | |
| <Card as="a" hasBorder> |
danielguillan
approved these changes
Jun 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug where index cards 404 on Next.js builds that specify a
basePath(like Primer sites).Testing: