Skip to content

Restore default index card wallpapers to work alongside custom basePath images - #47

Merged
rezrah merged 7 commits into
mainfrom
rezrah/fix-index-cards
Jun 20, 2025
Merged

Restore default index card wallpapers to work alongside custom basePath images#47
rezrah merged 7 commits into
mainfrom
rezrah/fix-index-cards

Conversation

@rezrah

@rezrah rezrah commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

Before:
Screenshot 2025-06-20 at 14 37 20

After:
Screenshot 2025-06-20 at 14 28 10

Copilot AI review requested due to automatic review settings June 20, 2025 13:27
@rezrah
rezrah requested a review from a team as a code owner June 20, 2025 13:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the thumbnail URL logic to ensure default index card wallpapers are used when custom images (with a basePath) are not provided.

  • Replaced the inline ?: '' basePath check with basePath || ''
  • Wrapped thumbnail paths in a null check before falling back to placeholders
  • Restored default wallpapers alongside custom basePath images

Comment thread packages/theme/components/layout/index-cards/IndexCards.tsx
Comment thread packages/theme/components/layout/index-cards/IndexCards.tsx
@rezrah
rezrah merged commit a5d3e10 into main Jun 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants