Fix inline code font size in headings - #48
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the font size of inline code inside headings and adjusts spacing under React code blocks, along with updating an example and the changeset.
- Add CSS rule so inline
<code>in headings inherits heading font size - Define
--spacingcustom property for code blocks and update spacing in example - Update example MDX and changelog entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/theme/css/prose.module.css | New rule to make inline code in headings inherit font-size |
| packages/theme/components/layout/code-block/ReactCodeBlock.module.css | Added --spacing custom property for code block spacing |
| packages/site/content/content-example/kitchen-sink.mdx | Added demo heading with inline code |
| .changeset/khaki-mugs-cover.md | Updated changelog to reflect CSS and spacing fixes |
Comments suppressed due to low confidence (1)
packages/theme/css/prose.module.css:215
- [nitpick] Consider adding a visual or snapshot test to verify that inline code within headings correctly inherits the heading font size across supported browsers.
.Prose :is(h1, h2, h3, h4, h5, h6):has(code) code:not(:global(.custom-component) code) {
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.