fix: generate TypeScript declarations explicitly in build script - #357
fix: generate TypeScript declarations explicitly in build script#357llastflowers with Copilot wants to merge 7 commits into
Conversation
Bumps and [picomatch](https://github.com/micromatch/picomatch). These dependencies needed to be updated together. Updates `picomatch` from 2.3.1 to 2.3.2 - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) Updates `picomatch` from 4.0.3 to 4.0.4 - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) Updates `picomatch` from 4.0.2 to 4.0.4 - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) --- updated-dependencies: - dependency-name: picomatch dependency-version: 2.3.2 dependency-type: indirect - dependency-name: picomatch dependency-version: 4.0.4 dependency-type: indirect - dependency-name: picomatch dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Agent-Logs-Url: https://github.com/primer/live-region-element/sessions/aaf39dcf-42d3-4ce0-962d-0e8aa60688c8 Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
…ix publint CI failure Agent-Logs-Url: https://github.com/primer/live-region-element/sessions/aaf39dcf-42d3-4ce0-962d-0e8aa60688c8 Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
|
@copilot Can you fix the formatting issue that is causing CI to fail here? |
…prettier check Agent-Logs-Url: https://github.com/primer/live-region-element/sessions/5a3b65f9-f5f4-4851-b6a3-f51abf30a994 Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
|
@copilot can you review this PR again with consideration to the most recent commit? |
Here's a review of the PR with all commits included: Changes:
Local verification:
|
|
closing in favor of #366 |
rollup-plugin-typescript2v0.36.0 silently stopped generating.d.tsfiles when paired with TypeScript 5.9.3, causingpublint --strictto fail with missing./dist/esm/index.d.tsand./dist/cjs/index.d.cts.Changes
packages/live-region-element/script/build: Replace implicit declaration generation viarollup-plugin-typescript2with an explicittscinvocation, then copy and rename for CJS:Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.