fix(sqlite): allow 32766 query params - #4810
Open
Weakky wants to merge 2 commits into
Open
Conversation
Contributor
Wasm Query Compiler File Size
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
✅ WASM query-engine performance won't change substantially (0.998x)Full benchmark reportAfter changes in 82cfce5 |
jkomyno
approved these changes
Jun 20, 2024
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughUpdates SQLite’s default maximum bind parameter count from 999 to 32766 in 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Quaint’s SQLite bind-parameter limit to reflect modern SQLite defaults, enabling larger batched queries and reducing unnecessary query chunking in Prisma Engines’ SQL query building layer.
Changes:
- Increase SQLite
max_bind_valuesdefault from999to32766inSqlFamily::default_max_bind_values().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
494
to
503
| pub fn default_max_bind_values(&self) -> usize { | ||
| match self { | ||
| #[cfg(feature = "postgresql")] | ||
| SqlFamily::Postgres => 32766, | ||
| #[cfg(feature = "mysql")] | ||
| SqlFamily::Mysql => 65535, | ||
| #[cfg(feature = "sqlite")] | ||
| SqlFamily::Sqlite => 999, | ||
| SqlFamily::Sqlite => 32766, | ||
| #[cfg(feature = "mssql")] | ||
| SqlFamily::Mssql => 2098, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
closes https://github.com/prisma/team-orm/issues/1048
Since SQLite 3.32.0, the max bind values were upgraded from 999 to 32766. As of commiting is, we're bundling SQLite 3.41.1.
This will improve performance for all queries that had more than 999 query params.