fix: fixing missing read parent - #5497
Closed
jacek-prisma wants to merge 2 commits into
Closed
Conversation
Contributor
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5497 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem with MySQL flavour when the foreign key relation mode is used with the query compiler. In this scenario our update node in the query graph ends up having no prior read node. The read node is necessary for databases that don't support
RETURNING. The query engine has a workaround for it which involves issuing queries dynamically at runtime whenever selectors for an update are missing but we can't do that in the query compiler workflow. I've modified how the graph is constructed to always add a read node prior to the update. I've also included a minor optimization for the case when relation mode is set to prisma (to avoid introducing a performance regression) - we avoid issuing a read query wheninsert_emulated_on_updateconnects no edges to it.