Skip to content

chore: remove no longer reachable code path - #5503

Merged
jacek-prisma merged 1 commit into
mainfrom
chore/remove-unreachable-path
Jun 26, 2025
Merged

chore: remove no longer reachable code path#5503
jacek-prisma merged 1 commit into
mainfrom
chore/remove-unreachable-path

Conversation

@jacek-prisma

@jacek-prisma jacek-prisma commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

This path is no longer reachable because the query graph for updates now always connect selectors for updates. This worked on MSSQL because it supports selectors even though it doesn't have the UpdateReturning capability. If we want MSSQL to leverage this we should look into enabling the capability instead. It'll make MSSQL query graphs simpler and likely faster to execute.

@codspeed-hq

codspeed-hq Bot commented Jun 26, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5503 will not alter performance

Comparing chore/remove-unreachable-path (8f97485) with main (6cbdedf)

Summary

✅ 11 untouched benchmarks

@github-actions

Copy link
Copy Markdown
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.184MiB 2.184MiB 0.000B
Postgres (gzip) 874.495KiB 874.493KiB 2.000B
Mysql 2.149MiB 2.149MiB 0.000B
Mysql (gzip) 859.676KiB 859.676KiB 0.000B
Sqlite 2.059MiB 2.059MiB 0.000B
Sqlite (gzip) 825.415KiB 825.415KiB 0.000B
SQL Server 2.115MiB 2.115MiB 0.000B
SQL Server (gzip) 849.280KiB 849.279KiB 1.000B

@aqrln aqrln added this to the 6.11.0 milestone Jun 26, 2025
@jacek-prisma
jacek-prisma merged commit c8c4e01 into main Jun 26, 2025
186 checks passed
@jacek-prisma
jacek-prisma deleted the chore/remove-unreachable-path branch June 26, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants