Skip to content

feat: ORM-1100 fix config validations - #5525

Merged
FGoessler merged 5 commits into
mainfrom
feat/orm-1100-fix-config-validations
Jul 10, 2025
Merged

feat: ORM-1100 fix config validations#5525
FGoessler merged 5 commits into
mainfrom
feat/orm-1100-fix-config-validations

Conversation

@FGoessler

@FGoessler FGoessler commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

This PR primarily fixes a panic during prisma db pull (see prisma/prisma#21386). This panic however was a symptom of missing validation and missing failed validation handling.

Closes prisma/prisma#21386

@FGoessler
FGoessler requested a review from a team July 9, 2025 15:41
@FGoessler FGoessler added this to the 6.12.0 milestone Jul 9, 2025
@codspeed-hq

codspeed-hq Bot commented Jul 9, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5525 will not alter performance

Comparing feat/orm-1100-fix-config-validations (98f6258) with main (c4261e4)

Summary

✅ 11 untouched benchmarks

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

WASM Query Engine File Size

Engine This PR Base branch Diff
Postgres 2.188MiB 2.188MiB 182.000B
Postgres (gzip) 868.262KiB 868.165KiB 100.000B
Mysql 2.154MiB 2.154MiB 182.000B
Mysql (gzip) 854.603KiB 854.653KiB -51.000B
Sqlite 2.062MiB 2.062MiB 182.000B
Sqlite (gzip) 817.254KiB 817.201KiB 55.000B
SQL Server 2.119MiB 2.119MiB 182.000B
SQL Server (gzip) 841.552KiB 841.528KiB 25.000B
CockroachDB 2.210MiB 2.210MiB 183.000B
CockroachDB (gzip) 876.869KiB 876.673KiB 200.000B

WASM Query Compiler File Size

Engine This PR Base branch Diff
Postgres 1.823MiB 1.823MiB 156.000B
Postgres (gzip) 720.968KiB 720.878KiB 92.000B
Mysql 1.788MiB 1.788MiB 156.000B
Mysql (gzip) 709.653KiB 709.523KiB 133.000B
Sqlite 1.741MiB 1.741MiB 156.000B
Sqlite (gzip) 690.255KiB 690.233KiB 23.000B
SQL Server 1.826MiB 1.826MiB 156.000B
SQL Server (gzip) 725.985KiB 725.685KiB 307.000B
CockroachDB 1.846MiB 1.846MiB 156.000B
CockroachDB (gzip) 729.890KiB 729.778KiB 115.000B

//  3 |  url = env("TEST_DATABASE_URL")
//  4 |  schemas = ["public", "sphere"]
//  | 
// error: @@schema is not supported on the current datasource provider

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ These tests changed as we now bail earlier in our validation logic as we deem the configuration invalid. The early return happens here due to the configuration validation here.

Comment thread schema-engine/sql-introspection-tests/tests/re_introspection/multi_file.rs Outdated
Co-authored-by: Oleksii (Alexey) Orlenko <alex@aqrln.net>
@FGoessler
FGoessler force-pushed the feat/orm-1100-fix-config-validations branch from b0ad95d to 98f6258 Compare July 10, 2025 09:41
@FGoessler
FGoessler merged commit cf92c4b into main Jul 10, 2025
200 checks passed
@FGoessler
FGoessler deleted the feat/orm-1100-fix-config-validations branch July 10, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introspection panics with multi schema on validation error with --force

2 participants