Skip to content

perf(query-compiler): specialize empty required set paths - #5829

Draft
tensordreams wants to merge 2 commits into
prisma-client-perf-required-set-pruningfrom
prisma-client-perf-empty-required-set-pruning
Draft

perf(query-compiler): specialize empty required set paths#5829
tensordreams wants to merge 2 commits into
prisma-client-perf-required-set-pruningfrom
prisma-client-perf-empty-required-set-pruning

Conversation

@tensordreams

Copy link
Copy Markdown
Contributor

Stacked performance split from the ongoing Prisma Client performance work.

What changed:

  • Stacks on required set pruning and specializes empty required set paths to avoid redundant graph phases.

Why:

  • Keeps this review unit small while preserving the measured allocation/runtime cleanup from the larger performance branch.

Validation:

  • See wip/client-performance-pr-stack.md on the Prisma status branch for the exact local check set recorded for this split.

CI linkage:
/prisma-branch prisma-client-performance-2026-06-08

Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: eb3aebc3-db22-41fd-b97b-634b631c66b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch prisma-client-perf-empty-required-set-pruning
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch prisma-client-perf-empty-required-set-pruning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Jun 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing prisma-client-perf-empty-required-set-pruning (cb760e9) with main (1171e96)2

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on prisma-client-perf-required-set-pruning (335dbb0) during the generation of this report, so main (1171e96) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions

Copy link
Copy Markdown
Contributor

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.553MiB 3.551MiB 1.770KiB
Postgres (gzip) 1.160MiB 1.159MiB 1.160KiB
Postgres (size-optimized) 1.785MiB 1.784MiB 784.000B
Postgres (size-optimized, gzip) 702.881KiB 702.848KiB 34.000B
Mysql 3.505MiB 3.504MiB 1.762KiB
Mysql (gzip) 1.144MiB 1.144MiB 506.000B
Mysql (size-optimized) 1.755MiB 1.754MiB 784.000B
Mysql (size-optimized, gzip) 691.519KiB 691.397KiB 125.000B
Sqlite 3.423MiB 3.422MiB 1.762KiB
Sqlite (gzip) 1.115MiB 1.115MiB 440.000B
Sqlite (size-optimized) 1.711MiB 1.710MiB 776.000B
Sqlite (size-optimized, gzip) 674.125KiB 673.956KiB 173.000B
SQL Server 3.641MiB 3.639MiB 1.658KiB
SQL Server (gzip) 1.177MiB 1.176MiB 270.000B
SQL Server (size-optimized) 1.783MiB 1.783MiB 784.000B
SQL Server (size-optimized, gzip) 705.333KiB 705.254KiB 80.000B
CockroachDB 3.603MiB 3.601MiB 1.658KiB
CockroachDB (gzip) 1.179MiB 1.178MiB 288.000B
CockroachDB (size-optimized) 1.810MiB 1.809MiB 776.000B
CockroachDB (size-optimized, gzip) 712.417KiB 712.176KiB 246.000B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants