Skip to content

perf(query-compiler): prune connect-or-create branches - #5830

Draft
tensordreams wants to merge 3 commits into
prisma-client-perf-empty-required-set-pruningfrom
prisma-client-perf-coc-branch-pruning
Draft

perf(query-compiler): prune connect-or-create branches#5830
tensordreams wants to merge 3 commits into
prisma-client-perf-empty-required-set-pruningfrom
prisma-client-perf-coc-branch-pruning

Conversation

@tensordreams

Copy link
Copy Markdown
Contributor

Stacked performance split from the ongoing Prisma Client performance work.

What changed:

  • Stacks on empty required set pruning and trims connect-or-create branch scaffolding where create/connect results can be joined or passed through directly.

Why:

  • Keeps this review unit small while preserving the measured allocation/runtime cleanup from the larger performance branch.

Validation:

  • See wip/client-performance-pr-stack.md on the Prisma status branch for the exact local check set recorded for this split.

CI linkage:
/prisma-branch prisma-client-performance-2026-06-08

Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 717cb62a-bba1-4573-9f0f-2c9757eaadb9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch prisma-client-perf-coc-branch-pruning
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch prisma-client-perf-coc-branch-pruning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Jun 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing prisma-client-perf-coc-branch-pruning (9a426d2) with prisma-client-perf-empty-required-set-pruning (cb760e9)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown
Contributor

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.552MiB 3.553MiB -907.000B
Postgres (gzip) 1.160MiB 1.160MiB -150.000B
Postgres (size-optimized) 1.785MiB 1.785MiB -107.000B
Postgres (size-optimized, gzip) 702.772KiB 702.887KiB -118.000B
Mysql 3.505MiB 3.505MiB -907.000B
Mysql (gzip) 1.144MiB 1.144MiB -269.000B
Mysql (size-optimized) 1.755MiB 1.755MiB -109.000B
Mysql (size-optimized, gzip) 691.497KiB 691.519KiB -23.000B
Sqlite 3.422MiB 3.423MiB -907.000B
Sqlite (gzip) 1.115MiB 1.115MiB -100.000B
Sqlite (size-optimized) 1.710MiB 1.711MiB -107.000B
Sqlite (size-optimized, gzip) 674.083KiB 674.124KiB -42.000B
SQL Server 3.640MiB 3.641MiB -901.000B
SQL Server (gzip) 1.177MiB 1.177MiB 55.000B
SQL Server (size-optimized) 1.783MiB 1.783MiB -107.000B
SQL Server (size-optimized, gzip) 705.399KiB 705.334KiB 67.000B
CockroachDB 3.602MiB 3.603MiB -901.000B
CockroachDB (gzip) 1.178MiB 1.179MiB -192.000B
CockroachDB (size-optimized) 1.810MiB 1.810MiB -107.000B
CockroachDB (size-optimized, gzip) 712.487KiB 712.418KiB 70.000B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants