chore(psl): unhide the typedSql preview feature - #5836
Conversation
Move TypedSql from the hidden preview-feature set to the active set, so that typedSql appears in schema tooling autocomplete and in the list of valid preview features shown by validation errors. The feature's behavior is unchanged: it was already valid and functional when enabled explicitly; only its visibility changes. ReactNative remains hidden. The two tests embedding the rendered list of visible features gain typedSql in their expected output. Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThis change reclassifies 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
Wasm Query Compiler File Size
|
Apply the review suggestion: a single-variant set does not need the brace form. Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
What
Moves the
TypedSqlpreview feature from the hidden set to the active set inpsl-core's feature classification (psl/psl-core/src/common/preview_features.rs).This is a visibility-only change — no behavior changes.
typedSqlwas already a valid, fully functional preview feature when enabled explicitly in a schema; being hidden only meant it was excluded from tooling surfaces (autocomplete in language tools) and from the "Expected one of: ..." list in validation error messages. After this change it appears in both.The two tests that embed the rendered list of visible preview features (
psl/psl/tests/config/generators.rsandpsl/psl/tests/validation/preview_features/native_full_text_search_postgres/mysql.prisma) gaintypedSqlin their expected output. No other test or snapshot in the repository pins the classification (verified by sweeping for the rendered list and forTypedSqlreferences).Why now
Prisma ORM's agent-native documentation work recommends TypedSQL as the escape hatch for several known pitfalls (e.g. full-text search on PostgreSQL), but neither users nor AI agents can discover a hidden flag: it never shows up in autocomplete or in the valid-feature listings that errors print. Making the feature visible closes that discoverability gap.
What stays as is
reactNativeremains hidden.typedSqlis explicitly out of scope — that would make$queryRawTypedgeneration unconditional and is a separate decision with its own compatibility questions.Validation
CLICOLOR_FORCE=1 cargo test -p psl --features all— 1,297 tests green (CLICOLOR_FORCEmatches the CI unit-test environment; the expect-test snapshots embed ANSI colors).cargo test -p psl-core --all-features— green.cargo fmt --check -p psl-core— clean.make test-unit, workspace-wide with--all-features) is the authoritative surface for the remaining crates; a repository-wide sweep found no other snapshot embedding the visible-features list.