allow for custom protocol implementations to skip Has* methods#282
Open
daaku wants to merge 1 commit intoprogrium:mainfrom
Open
allow for custom protocol implementations to skip Has* methods#282daaku wants to merge 1 commit intoprogrium:mainfrom
daaku wants to merge 1 commit intoprogrium:mainfrom
Conversation
Owner
|
Yeah, we inherited this design from a project that was absorbed and it always bugged me. I believe this is fine and I would really like this. Will leave this open for now to see if anybody else has input and also because I haven't had time to properly maintain/push forward lately. I usually work in bursts, but I'll be looking into this in the next burst. I guess one thing people could do to help expedite is to try this branch and see that all the examples work, that their programs still work, etc and report back here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider this change carefully - I'm not so familiar with the implications.
In experimenting with implementing a protocol using a custom struct, I found that for optional methods, the
HasXXXmethod was required. This change makes it such that if the methodXXXis implemented, but the correspondingHasXXXis not implemented, the method/selector is considered to be implemented.This came out of me exploring the tableview example. Here's a significantly simpler version of the example (albeit without the dynamically changing data) using a custom
NSTableViewDataSourceimplementation:https://gist.github.com/daaku/be2cd99b492cfc75ba1efe23ca56acd0