Mach speed uncertainty#84
Open
presidente20 wants to merge 29 commits into
Open
Conversation
…ch uncertainty changes seem to have affected time to reach EGRR and cause test to fail with previous value.
ahdgkn
requested changes
Jun 11, 2026
ahdgkn
left a comment
Contributor
There was a problem hiding this comment.
Requesting two changes:
- Assign mach values such that the mach and cas profiles give the same TAS at each FL
- Calculate the transition altitude from the cas and mach values of the aircraft after uncertainty is applied, rather than the nominal values (is_below_transition() in LinearPredictor) - this avoids need of perfectly aligning the CAS/Mach uncertainty
…m nominal value lookup
…flight phase rather than always cruise
c2fa6bf to
5b57bd7
Compare
… against null profiles
ahdgkn
previously approved these changes
Jun 18, 2026
ahdgkn
left a comment
Contributor
There was a problem hiding this comment.
Happy with changes to remove discontinuity at CAS-mach transition. Profiles for simple mode look realistic. Runs without bugs on a Springfield scenario.
added 2 commits
June 19, 2026 13:58
ahdgkn
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the application of Mach uncertainty to lateral speeds in a similar manner to the way it is done for CAS.
I will create a Starling PR with some small follow up changes to match this PR.