Skip to content

Mach speed uncertainty#84

Open
presidente20 wants to merge 29 commits into
devfrom
mach-speed-uncertainty
Open

Mach speed uncertainty#84
presidente20 wants to merge 29 commits into
devfrom
mach-speed-uncertainty

Conversation

@presidente20

@presidente20 presidente20 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This PR adds the application of Mach uncertainty to lateral speeds in a similar manner to the way it is done for CAS.

  • Apply speed uncertainty to Mach speeds in cas_and_mach_from_table.
  • Add mach_cl/mach_cr/mach_des profile values and uncertainty parameters for all six weight classes in the performance profile and uncertainty data files (this will also be added in the Starling uncertainty file).
  • Move the CAS uncertainty application out of the interpolation else branch so it runs in all cases, which is consistent with the way it is done for vertical speeds and now Mach speeds.
  • Rework the predictor tests to drop the defunct "full mode"/"simple mode" terminology (now "user-supplied" vs "fallback" performance data).
  • Bump the test_springfield::test_landing per-step evolve time (10 → 12) to account for the slightly slower time-to-fix introduced by Mach uncertainty.

I will create a Starling PR with some small follow up changes to match this PR.

@presidente20 presidente20 marked this pull request as ready for review June 5, 2026 07:56
natsmike
natsmike previously approved these changes Jun 8, 2026

@natsmike natsmike left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ahdgkn ahdgkn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting two changes:

  1. Assign mach values such that the mach and cas profiles give the same TAS at each FL
  2. Calculate the transition altitude from the cas and mach values of the aircraft after uncertainty is applied, rather than the nominal values (is_below_transition() in LinearPredictor) - this avoids need of perfectly aligning the CAS/Mach uncertainty

@presidente20 presidente20 force-pushed the mach-speed-uncertainty branch from c2fa6bf to 5b57bd7 Compare June 17, 2026 09:34
@ahdgkn ahdgkn self-requested a review June 18, 2026 11:17
ahdgkn
ahdgkn previously approved these changes Jun 18, 2026

@ahdgkn ahdgkn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes to remove discontinuity at CAS-mach transition. Profiles for simple mode look realistic. Runs without bugs on a Springfield scenario.

@presidente20 presidente20 requested a review from ahdgkn June 19, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants