[OTA PROVIDER] - Read ApplyUpdateRequest as a flag using named pipes#72177
Open
jtrejoespinoza-grid wants to merge 17 commits into
Open
[OTA PROVIDER] - Read ApplyUpdateRequest as a flag using named pipes#72177jtrejoespinoza-grid wants to merge 17 commits into
jtrejoespinoza-grid wants to merge 17 commits into
Conversation
…t by the provider
for more information, see https://pre-commit.ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a status tracking mechanism for OTA apply update requests using named pipes. It adds a boolean flag to OTAProviderExample to track sent requests and introduces a new command, GetApplyUpdateRequestStatus, in the command delegate to report this status via JSON. The Python test TC_SU_2_5.py is updated to verify these statuses during the update process. Review feedback identifies several typos in the new function names (e.g., 'BuildAppy' instead of 'BuildApply'), an unused variable in the command handler, a return type mismatch in a getter, and a configuration issue where the input and output pipes were defaulting to the same file path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72177 +/- ##
=======================================
Coverage 56.08% 56.08%
=======================================
Files 1640 1640
Lines 112462 112462
Branches 13316 13316
=======================================
Hits 63074 63074
Misses 49388 49388 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72177: Size comparison from 7f05a3a to 8a36708 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #72177: Size comparison from 7f05a3a to 726f47d Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
for more information, see https://pre-commit.ci
…ore test line once is completed
…esending. Requestor should not apply the software update
|
PR #72177: Size comparison from b47b58c to 8a3aaa5 Full report (21 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #72177: Size comparison from b47b58c to f7fdf7c Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of testing for the test TC_SU_2_5 we need to be able tor read the values sent from the ApplyUpdateRequest action from the Provider, as we can not modify requestor behavior the Test need to be able to to read these values from the Provider, this will allow the test to assert the values and ensure we can terminate the provider properly before Re-request the ApplyUpdateRequest.
The idea for this is because we do not want to apply multiple software updates as is not really needed for the propose of the test.
Additionally the test TC_SU_2.5 is reduced to 3 steps ( 3,4 and 5) and remove step 1 and step 2 which will be validated on different test cases.
Related issues
#Fixes project-chip/matter-test-scripts#786
Testing
Build the Provider and Requestor apps:
Provider App
./scripts/examples/gn_build_example.sh examples/ota-provider-app/linux out/debug chip_config_network_layer_ble=falseRequestor App
./scripts/examples/gn_build_example.sh examples/ota-requestor-app/linux out/debug chip_config_network_layer_ble=falseRun the test using:
python3 scripts/tests/run_python_test.py --load-from-env /tmp/test_env.yaml --script src/python_testing/TC_SU_2_5.pyReadability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable: