-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Nigthly Fix for Slow Tests #72549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jtrejoespinoza-grid
wants to merge
10
commits into
project-chip:master
Choose a base branch
from
jtrejoespinoza-grid:nightly_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nigthly Fix for Slow Tests #72549
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ebf14b7
Fix timeout issue for nightly jobs on run_python_test
jtrejoespinoza-grid 73306c5
Merge branch 'project-chip:master' into nightly_fix
jtrejoespinoza-grid a336c1f
Added terminate to task wait. Increased TERMINATE_TIMEOUT to avoid re…
jtrejoespinoza-grid dc2cc97
Uncomment for testing. Revert after completed
jtrejoespinoza-grid 0198790
Validation for timeout and provide feedback
jtrejoespinoza-grid a9d85e7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9535bd2
Conflict solved
jtrejoespinoza-grid e18b1f2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 565e531
Simplification of the wait().
jtrejoespinoza-grid 6781a61
Merge branch 'master' into nightly_fix
jtrejoespinoza-grid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual --timeout lookup in run_python_test.py only handles the space-separated form (--timeout 20). It looks for a standalone --timeout token and reads the next one. With --timeout=20, shlex.split() produces a single token, so the lookup misses it, test_arg_timeout stays None, and the outer Subprocess.wait() falls back to the 300s default — silently undoing the fix this PR is trying to make.
No current caller uses the = form (CI metadata uses --timeout 1800, etc.), so this is latent rather than a live bug.
runner.py already parses --timeout via argparse (type=int), which handles both forms and validates the value. Worth reusing that here (e.g. a small parse_known_args with just --timeout) instead of hand-parsing, so the orchestrator and the test script read the flag the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I far I know we don't use that format for CI arguments in the
CI TEST ARGUMENTSsection from python tests.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way only a few tests use "=" for arguments and for what I see only for app arguments and not for script arguments:
You can check by using sed on src/python_testing
sed -n '/BEGIN CI TEST ARGUMENTS/,/END CI TEST ARGUMENTS/p' src/python_testing/*py | grep -v "===" | grep =