[TC-GC-2.8] Validate GroupcastTesting event in Python test#72737
Merged
mergify[bot] merged 5 commits intoJun 26, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the TC_GC_2_8.py test script to include comprehensive testing steps and logic for Groupcast Listener nodes, covering group membership, access control, and decryption failure scenarios. The review feedback highlights two issues: an undefined logger variable on line 171 that will cause a NameError (suggesting logging.info instead), and an incorrect step range in mark_step_range_skipped(5, 17) on line 307, which should be (5, 16) since step 17 is meant to be executed.
|
PR #72737: Size comparison from e2077a4 to 675223b Full report (30 builds for cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72737 +/- ##
==========================================
- Coverage 56.76% 56.61% -0.15%
==========================================
Files 1634 1642 +8
Lines 112660 113137 +477
Branches 13144 13243 +99
==========================================
+ Hits 63946 64048 +102
- Misses 48714 49089 +375 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72737: Size comparison from e2077a4 to 1286580 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
lpbeliveau-silabs
approved these changes
Jun 26, 2026
…th the provided epochkey. Use those helper in GC_2-8 step 13 to exercise the FailAuth path
for more information, see https://pre-commit.ci
|
PR #72737: Size comparison from e2077a4 to 59af9c9 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
tcarmelveilleux
approved these changes
Jun 26, 2026
|
PR #72737: Size comparison from e2077a4 to 7e2cde3 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
TC_GC_2_8.pyonly validates theFabricUnderTestattribute side effect of theGroupcastTestingcommand. TheGroupcastTestingevent itself is never validated, so a mandatory spec behavior is untested.Solution
TC_GC_2_8.pyto validate theGroupcastTestingevent through the Listener flow, interleaved with the existingFabricUnderTestattribute checks.GroupKeyMapcleared so no key is available to decrypt.TC_GC_common.py(get_feature_map,get_operate_only_commands,get_iana_multicast_address,generate_fabric_under_test_matcher).Caveats
FabricUnderTestattribute behavior is validated in that case.Related issues
Testing
TC_GC_2_8.py, run againstall-devices-app --device on-off-light:1 --groupcast.