Matter netman add rpcd#50
Conversation
rmelotte
force-pushed
the
matter-netman-add-rpcd
branch
from
bc60381 to
9cbf355
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds rpcd to the dependencies of matter-netman and changes PKG_BUILD_DEPENDS to HOST_BUILD_DEPENDS in python3-host-ssl. However, changing the build dependency in python3-host-ssl can break build order tracking and lead to parallel build failures, so it is recommended to revert this change.
I am having trouble creating individual review comments. Click here to see my feedback.
devel/python3-host-ssl/Makefile (22)
In OpenWrt, package-level build dependency tracking (even for host-only packages with PKG_HOST_ONLY:=1) relies on PKG_BUILD_DEPENDS to determine the build order. Changing this to HOST_BUILD_DEPENDS means the build system will not guarantee that python3/host is built before python3-host-ssl. This can lead to race conditions and build failures in clean or parallel builds (e.g., make -j). Please revert this to PKG_BUILD_DEPENDS.
PKG_BUILD_DEPENDS:=python3/host
|
Note: I initially pushed an additional commit that didn't belong here (about |
rmelotte
force-pushed
the
matter-netman-add-rpcd
branch
from
9cbf355 to
c267c13
Compare
We need rpcd to query the UCI configuration over ubus. Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
rmelotte
force-pushed
the
matter-netman-add-rpcd
branch
from
c267c13 to
18005db
Compare
| CATEGORY:=Network | ||
| TITLE:=Matter Network Infrastructure Manager Daemon | ||
| URL:=https://github.com/project-chip/connectedhomeip | ||
| DEPENDS:=+libstdcpp +libatomic +libubus +libubox +jsonfilter |
There was a problem hiding this comment.
The dependency is fine, but it's a little odd as a standalone PR since nothing is pulling in any code to actually read UCI config yet? Are you implementing that code in the example app in the SDK repo? If so we can add this dependency when we also pull in a later version of the example app that has that code.
There was a problem hiding this comment.
Yes indeed, we're using it in the example app in the SDK repo.
The idea was to already add the dependency here so that it's easier for other people to use it without having to pull it in manually, but waiting until the changes are merged in the SDK repo would also be fine IMO.
We're still finalizing the changed for the SDK repo, there is no PR for it yet.
2 participants
We need rpcd to query the UCI configuration over ubus.