Skip to content

feat: support secret/configMap mounting via arbitrary volume sources - #198

Merged
dgrove-oss merged 1 commit into
project-codeflare:mainfrom
C-nit:feat/volume-sources-support
Jul 9, 2026
Merged

feat: support secret/configMap mounting via arbitrary volume sources#198
dgrove-oss merged 1 commit into
project-codeflare:mainfrom
C-nit:feat/volume-sources-support

Conversation

@C-nit

@C-nit C-nit commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Issue link

Closes #197

What changes have been made

  • _helpers.tpl: while the claimName shorthand is kept, anything else passed through as a verbatim volume source
  • values.yaml: reworded doc comment + four examples (PVC shorthand, verbose PVC, configMap, secret-with-items).
  • README.md: match values comment
  • tests/helloworld_test.yaml + .snap: the three new sources appended to the existing "Adding Volume Mounts" test; snapshot regenerated.

Verification steps

  • extended unittest, passes
  • compared compiled manifest to the result using the kustomize workaround mentioned in the linked issue.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@C-nit

C-nit commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/helm-unittest/helm-unittest#install
I see the github actions need to either pin the installation of helm to version 3, or add --no-verify to the unittest plugin installation.

I wait for maintainer feedback before touching CI.

@dgrove-oss

dgrove-oss commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

@C-nit -- please rebase to latest main to pick up a fix for CI.

You'll also have to fix the signature on your commit; hopefully you can do that without too much annoyance.

Thanks!

@C-nit
C-nit force-pushed the feat/volume-sources-support branch from 406b605 to 9ee56cc Compare July 9, 2026 10:51

@dgrove-oss dgrove-oss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dgrove-oss
dgrove-oss merged commit b6d97bf into project-codeflare:main Jul 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow secret mounting, not only pvc

2 participants