Skip to content

kwok and perf updates#695

Open
jbusche wants to merge 2 commits into
project-codeflare:mainfrom
jbusche:jbusche-perf-improvements
Open

kwok and perf updates#695
jbusche wants to merge 2 commits into
project-codeflare:mainfrom
jbusche:jbusche-perf-improvements

Conversation

@jbusche

@jbusche jbusche commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Issue link

#625

What changes have been made

  • Fixed the KWOK install instructions to the latest (easier) method
  • Fixed the Items problem so that appwrappers launch
  • Changed to a while loop that allows as few as 1 appwrapper or fake node to work now (didn't work before with the for loop)

Verification steps

Testing both from a MAC and on my OpenShift cluster

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: James Busche <jbusche@us.ibm.com>
@openshift-ci

openshift-ci Bot commented Dec 5, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign metalcycling for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbusche

jbusche commented Dec 5, 2023

Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: James Busche <jbusche@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant