feat(server): notify systemd when ready#4008
Draft
AkashKumar7902 wants to merge 1 commit into
Draft
Conversation
AkashKumar7902
force-pushed
the
issue-2188-systemd-notify
branch
from
3f7bbe3 to
63dfb57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
READY=1throughgo-systemdwhen zot reaches its existing ready state/readyzas the readiness source and notify after the HTTP listener is boundexamples/zot.servicetoType=notifywithNotifyAccess=mainFixes #2188
Testing
GOEXPERIMENT=jsonv2 go test -tags "sync scrub metrics search lint userprefs mgmt imagetrust ui" ./pkg/api -run TestMarkReadyNotifiesSystemd -count=1GOEXPERIMENT=jsonv2 go test ./pkg/api ./pkg/cli/server -run TestDoesNotExist -count=1GOEXPERIMENT=jsonv2 go test -tags "sync scrub metrics search lint userprefs mgmt imagetrust ui" ./pkg/api -run 'TestRunPortZeroTracksChosenPort|TestMarkReadyNotifiesSystemd' -count=1\n-GOEXPERIMENT=jsonv2 go test -tags "sync scrub metrics search lint userprefs mgmt imagetrust ui" ./pkg/cli/server -run TestServe -count=1\n-GOEXPERIMENT=jsonv2 go vet -tags "sync scrub metrics search lint userprefs mgmt imagetrust ui" ./pkg/api ./pkg/cli/server\n-git diff --check