Skip to content

Test on Blacklight 9 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcoyne merged 1 commit into from
Mar 26, 2026
Merged

Test on Blacklight 9 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ jobs:
blacklight_version: "~> 8.0"
additional_name: "with legacy partial config"
legacy_config: "true"
- ruby: "3.4"
rails_version: "8.1.3"
blacklight_version: "~> 9.0"
additional_name: "Blacklight 9"
env:
RAILS_VERSION: ${{ matrix.rails_version }}
BLACKLIGHT_VERSION: ${{ matrix.blacklight_version }}
Expand Down
7 changes: 4 additions & 3 deletions app/components/blacklight/oembed/document_oembed_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
module Blacklight
module Oembed
class DocumentOembedComponent < Blacklight::Component
attr_reader :document, :presenter, :classes
attr_reader :presenter, :classes

def initialize(document:, presenter:, classes: ['oembed-widget'], **kwargs)
def initialize(presenter:, classes: ['oembed-widget'], **kwargs)
super()

@document = document
@presenter = presenter
@classes = classes
end

delegate :document, to: :presenter

def embed
return if embed_url.blank?

Expand Down
2 changes: 1 addition & 1 deletion app/views/catalog/_oembed_default.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<%= render Blacklight::Oembed::DocumentOembedComponent.new(document: document, presenter: document_presenter(document)) %>
<%= render Blacklight::Oembed::DocumentOembedComponent.new(presenter: document_presenter(document)) %>
2 changes: 1 addition & 1 deletion blacklight-oembed.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.add_dependency 'blacklight', '>= 7.25', '< 9'
spec.add_dependency 'blacklight', '>= 7.25', '< 10'
spec.add_dependency 'rails'
spec.add_dependency 'ruby-oembed'
spec.add_dependency 'view_component', '>= 3.0'
Expand Down
Loading