Merged
Conversation
hedibouattour
force-pushed
the
add-recover-in-vpp-manager
branch
3 times, most recently
from
f89e449 to
3cad64e
Compare
sknat
reviewed
Feb 20, 2026
hedibouattour
force-pushed
the
add-recover-in-vpp-manager
branch
from
3cad64e to
5a20e45
Compare
Previously, any return from the VPP manager was treated as an indication that VPP had exited or crashed, triggering configuration restoration. However, if the VPP manager itself panicked while VPP was still running, the deferred logic would interpret this as a VPP crash and attempt to restore the configuration. Since VPP was actually still alive, the restoration could hang and the original panic would never be properly surfaced. This change adds panic recovery in the VPP manager to prevent false assumptions about VPP state and avoid blocking during restore when the failure originates in the manager itself. When VPPmanager crashes we kill VPP, wait a bit, then restore the config.
hedibouattour
force-pushed
the
add-recover-in-vpp-manager
branch
from
5a20e45 to
74af098
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any return from the VPP manager was treated as an indication
that VPP had exited or crashed, triggering configuration restoration.
However, if the VPP manager itself panicked while VPP was still running,
the deferred logic would interpret this as a VPP crash and attempt to
restore the configuration. Since VPP was actually still alive, the
restoration could hang and the original panic would never be properly
surfaced.
This change adds panic recovery in the VPP manager to prevent false
assumptions about VPP state and avoid blocking during restore when the
failure originates in the manager itself.
When VPPmanager crashes we kill VPP, wait a bit, then restore the config.